Re: [ovs-dev] [PATCH] ofproto-dpif: Print register values in trace.

2011-08-12 Thread Ethan Jackson
Thanks for the review, I pushed this. Ethan On Fri, Aug 12, 2011 at 15:26, Ben Pfaff wrote: > On Fri, Aug 12, 2011 at 03:22:52PM -0700, Ethan Jackson wrote: >> I found this patch useful in tracking down a bug recently. > > Good idea. > > Regs have type uint32_t so the right format specifier is "

Re: [ovs-dev] [PATCH] ofproto-dpif: Print register values in trace.

2011-08-12 Thread Ben Pfaff
On Fri, Aug 12, 2011 at 03:22:52PM -0700, Ethan Jackson wrote: > I found this patch useful in tracking down a bug recently. Good idea. Regs have type uint32_t so the right format specifier is "%"PRIx32 (not %x). I think you probably don't want to make it print trailing white space in case we eve

[ovs-dev] [PATCH] ofproto-dpif: Print register values in trace.

2011-08-12 Thread Ethan Jackson
I found this patch useful in tracking down a bug recently. --- ofproto/ofproto-dpif.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index fdef4af..edc9ccb 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofp