Fair enough. I added a comment and pushed.
On Thu, Dec 29, 2011 at 12:10:41AM -0600, Justin Pettit wrote:
> Ben, do you think it's worth putting a small comment above the assignment?
> Otherwise, it looks kind of odd.
>
> --Justin
>
>
> On Dec 28, 2011, at 10:50 PM, Ethan Jackson wrote:
>
>
Ben, do you think it's worth putting a small comment above the assignment?
Otherwise, it looks kind of odd.
--Justin
On Dec 28, 2011, at 10:50 PM, Ethan Jackson wrote:
> Looks good.
>
> Ethan
>
> On Tue, Dec 27, 2011 at 14:32, Ben Pfaff wrote:
>> gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-48)
Looks good.
Ethan
On Tue, Dec 27, 2011 at 14:32, Ben Pfaff wrote:
> gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-48) warned:
>
> ofproto/ofproto-dpif.c: In function 'bundle_send_learning_packets':
> ofproto/ofproto-dpif.c:1835: warning: dereferencing type-punned pointer
> will break strict-a
gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-48) warned:
ofproto/ofproto-dpif.c: In function 'bundle_send_learning_packets':
ofproto/ofproto-dpif.c:1835: warning: dereferencing type-punned pointer
will break strict-aliasing rules
I agree that its analysis matches what the C standard says.
