Re: [ovs-dev] [PATCH] ofproto-dpif: Fix 'size' argument to fix_sflow_action().

2013-04-30 Thread Ben Pfaff
t; > > To: dev@openvswitch.org > > Cc: "Ben Pfaff" , "Dhaval Badiani" > > Sent: Tuesday, April 30, 2013 11:07:11 AM > > Subject: [ovs-dev] [PATCH] ofproto-dpif: Fix 'size' argument to > > fix_sflow_action(). > > > > Th

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix 'size' argument to fix_sflow_action().

2013-04-30 Thread Romain Lenglet
LGTM. I introduced this bug. Thanks a lot for fixing it! -- Romain Lenglet - Original Message - > From: "Ben Pfaff" > To: dev@openvswitch.org > Cc: "Ben Pfaff" , "Dhaval Badiani" > Sent: Tuesday, April 30, 2013 11:07:11 AM > Subject: [ovs-d

[ovs-dev] [PATCH] ofproto-dpif: Fix 'size' argument to fix_sflow_action().

2013-04-30 Thread Ben Pfaff
The sflow action only uses 8 bytes of the total 16 for user_action_cookie, but fix_sflow_action() was checking for the presence of all 8, so if the sflow action wasn't followed by a few other actions then 'cookie' would end up NULL and the assertion would segfault. Bug #16659. Reported-by: Dhaval