Re: [ovs-dev] [PATCH] ofproto-dpif: Add more lock annotations.

2014-01-16 Thread Ben Pfaff
On Thu, Jan 16, 2014 at 08:15:18AM +0900, YAMAMOTO Takashi wrote: > > This annotation would have caught the bug fixed by commit 491a67a0005347130 > > (ofproto-dpif-xlate: Avoid recursive acquisition of xlate_rwlock.). > > looks good to me. > > unless there's a more generic way to detect recursive

Re: [ovs-dev] [PATCH] ofproto-dpif: Add more lock annotations.

2014-01-15 Thread YAMAMOTO Takashi
> This annotation would have caught the bug fixed by commit 491a67a0005347130 > (ofproto-dpif-xlate: Avoid recursive acquisition of xlate_rwlock.). looks good to me. unless there's a more generic way to detect recursive read-lock. (i don't know) YAMAMOTO Takashi > > Signed-off-by: Ben Pfaff >

[ovs-dev] [PATCH] ofproto-dpif: Add more lock annotations.

2014-01-15 Thread Ben Pfaff
This annotation would have caught the bug fixed by commit 491a67a0005347130 (ofproto-dpif-xlate: Avoid recursive acquisition of xlate_rwlock.). Signed-off-by: Ben Pfaff CC: YAMAMOTO Takashi --- ofproto/ofproto-dpif-xlate.c |1 + ofproto/ofproto-dpif.h |8 ++-- 2 files changed,