Re: [ovs-dev] [PATCH] ofproto: flush groups and meters in ofproto_flush__

2014-10-02 Thread Joe Stringer
Hmm. This time the patch is littered with extra spaces all through the email. If you're able to use them, "git format-patch" and "git send-email" is a good way to send your patches out reliably without mail clients interfering with the presentation of the patch. I took a look at the group deletio

Re: [ovs-dev] [PATCH] ofproto: flush groups and meters in ofproto_flush__

2014-10-01 Thread Gur Stavi
ovs-dev] [PATCH] ofproto: flush groups and meters in ofproto_flush__ Hi Gur, looks straightforward. I have a few broad feedback points though: If you haven't read it yet, please take a look at the CONTRIBUTING file in the top of the source tree. I'm not sure what format this patch is in, b

[ovs-dev] [PATCH] ofproto: flush groups and meters in ofproto_flush__

2014-10-01 Thread Gur Stavi
In fail-open mode on disconnect from controller rules are flushed. It makes sense to flush groups and meters as well. Signed-off-by: Gur Stavi --- Original issue was discussed here: https://www.mail-archive.com/discuss@openvswitch.org/msg10930.html Resending to avoid email client auto sig

Re: [ovs-dev] [PATCH] ofproto: flush groups and meters in ofproto_flush__

2014-10-01 Thread Joe Stringer
Hi Gur, looks straightforward. I have a few broad feedback points though: If you haven't read it yet, please take a look at the CONTRIBUTING file in the top of the source tree. I'm not sure what format this patch is in, but git won't accept it in my setup. I suspect it's due to the footer message

[ovs-dev] [PATCH] ofproto: flush groups and meters in ofproto_flush__

2014-09-30 Thread Gur Stavi
In fail-open mode on disconnect from controller rules are flushed. It makes sense to flush groups and meters as well. Signed-off-by: Gur Stavi gst...@mrv.com --- Original issue was discussed here: https://www.mail-archive.com/discuss@openvswitch.org/msg10930.html Index: of