Re: [ovs-dev] [PATCH] ofproto: fix checking of packet_in_mask in async config

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 11:18:38PM +, Shu Shen wrote: > Have you got a chance to look at the below patch? I was behind in review (I still am). Thanks for the patch! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ofproto: fix checking of packet_in_mask in async config

2014-11-25 Thread Ben Pfaff
On Fri, Nov 21, 2014 at 04:27:25PM -0800, Shu Shen wrote: > The check shall use wire protool reasons, which could be different from > the internal packet-in reason. > > Signed-off-by: Shu Shen Thanks for finding the bug and for fixing it! I applied this to master. __

Re: [ovs-dev] [PATCH] ofproto: fix checking of packet_in_mask in async config

2014-11-25 Thread Shu Shen
Hi Ben, Have you got a chance to look at the below patch? In the test case, wire_reason() translate OFPR_ACTION to OFPR_NO_MATCH, but OFPR_ACTION (as the value of pin->up.reason) was still passed to ofconn_receives_async_msg() to check whether the packet-in shall be sent or not - which it deci

[ovs-dev] [PATCH] ofproto: fix checking of packet_in_mask in async config

2014-11-21 Thread Shu Shen
The check shall use wire protool reasons, which could be different from the internal packet-in reason. Signed-off-by: Shu Shen --- ofproto/connmgr.c | 2 +- tests/ofproto-dpif.at | 62 +++ 2 files changed, 63 insertions(+), 1 deletion(-) diff