Re: [ovs-dev] [PATCH] ofproto: Inline trivial functions.

2014-04-29 Thread Jarno Rajahalme
Pushed, thanks for the review! Jarno On Apr 29, 2014, at 3:11 PM, Ben Pfaff wrote: > On Tue, Apr 29, 2014 at 03:01:47PM -0700, Jarno Rajahalme wrote: >> >> On Apr 29, 2014, at 2:55 PM, Jarno Rajahalme wrote: >> >>> >>> On Apr 24, 2014, at 9:18 AM, Ben Pfaff wrote: >>> On Thu, Apr 2

Re: [ovs-dev] [PATCH] ofproto: Inline trivial functions.

2014-04-29 Thread Ben Pfaff
On Tue, Apr 29, 2014 at 03:01:47PM -0700, Jarno Rajahalme wrote: > > On Apr 29, 2014, at 2:55 PM, Jarno Rajahalme wrote: > > > > > On Apr 24, 2014, at 9:18 AM, Ben Pfaff wrote: > > > >> On Thu, Apr 24, 2014 at 09:09:03AM -0700, Jarno Rajahalme wrote: > >>> rule_dpif_is_internal is among the t

Re: [ovs-dev] [PATCH] ofproto: Inline trivial functions.

2014-04-29 Thread Jarno Rajahalme
On Apr 29, 2014, at 2:55 PM, Jarno Rajahalme wrote: > > On Apr 24, 2014, at 9:18 AM, Ben Pfaff wrote: > >> On Thu, Apr 24, 2014 at 09:09:03AM -0700, Jarno Rajahalme wrote: >>> rule_dpif_is_internal is among the top ten OVS internal functions in >>> recent perf reports. Inline it and some oth

Re: [ovs-dev] [PATCH] ofproto: Inline trivial functions.

2014-04-29 Thread Jarno Rajahalme
On Apr 24, 2014, at 9:18 AM, Ben Pfaff wrote: > On Thu, Apr 24, 2014 at 09:09:03AM -0700, Jarno Rajahalme wrote: >> rule_dpif_is_internal is among the top ten OVS internal functions in >> recent perf reports. Inline it and some other equally trivial >> functions. >> >> This change removes rule

Re: [ovs-dev] [PATCH] ofproto: Inline trivial functions.

2014-04-24 Thread Ben Pfaff
On Thu, Apr 24, 2014 at 09:09:03AM -0700, Jarno Rajahalme wrote: > rule_dpif_is_internal is among the top ten OVS internal functions in > recent perf reports. Inline it and some other equally trivial > functions. > > This change removes rule_is_internal(), since the fact that a table is > an inte

[ovs-dev] [PATCH] ofproto: Inline trivial functions.

2014-04-24 Thread Jarno Rajahalme
rule_dpif_is_internal is among the top ten OVS internal functions in recent perf reports. Inline it and some other equally trivial functions. This change removes rule_is_internal(), since the fact that a table is an internal one is defined within ofproto-dpif, not ofproto. Signed-off-by: Jarno R