Re: [ovs-dev] [PATCH] ofproto: Fix memory leak and memory exhaustion bugs in group_mod.

2016-01-18 Thread Ben Pfaff
I reposted this as the first patch in a new series: https://patchwork.ozlabs.org/patch/569826/ Please review it there (although it hasn't changed). ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ofproto: Fix memory leak and memory exhaustion bugs in group_mod.

2016-01-13 Thread Ben Pfaff
In handle_group_mod() cases where adding a group failed, nothing freed the list of buckets, causing a leak. The same was true in every case of modifying a group. This commit fixes the problem by changing add_group() to never steal or free the buckets (modify_group() already acted this way) and th