Re: [ovs-dev] [PATCH] ofproto: Avoid extra O(N) work in common case on flow addition.

2013-08-15 Thread Ben Pfaff
Thanks, applied. On Fri, Aug 16, 2013 at 08:51:18AM +0800, Ethan Jackson wrote: > Acked-by: Ethan Jackson > > Thanks a lot. > > On Fri, Aug 16, 2013 at 8:39 AM, Ben Pfaff wrote: > > The OpenFlow OFPFF_CHECK_OVERLAP flag requires us to check whether the flow > > being inserted overlaps with any

Re: [ovs-dev] [PATCH] ofproto: Avoid extra O(N) work in common case on flow addition.

2013-08-15 Thread Ethan Jackson
Acked-by: Ethan Jackson Thanks a lot. On Fri, Aug 16, 2013 at 8:39 AM, Ben Pfaff wrote: > The OpenFlow OFPFF_CHECK_OVERLAP flag requires us to check whether the flow > being inserted overlaps with any existing flows. That isn't efficiently > implemented and typically requires us to compare the

[ovs-dev] [PATCH] ofproto: Avoid extra O(N) work in common case on flow addition.

2013-08-15 Thread Ben Pfaff
The OpenFlow OFPFF_CHECK_OVERLAP flag requires us to check whether the flow being inserted overlaps with any existing flows. That isn't efficiently implemented and typically requires us to compare the new flow against most or all of the existing flows. We don't have to do that work if OFPFF_CHECK