Re: [ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-11-01 Thread Ben Pfaff
On Fri, Oct 25, 2013 at 02:25:10PM -0700, Ben Pfaff wrote: > On Fri, Oct 25, 2013 at 02:04:44PM -0700, Jarno Rajahalme wrote: > > > > On Oct 25, 2013, at 1:56 PM, Ben Pfaff wrote: > > > > > On Fri, Oct 25, 2013 at 01:44:17PM -0700, Jarno Rajahalme wrote: > > >> > > >> On Oct 25, 2013, at 1:32 P

Re: [ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-10-25 Thread Ben Pfaff
On Fri, Oct 25, 2013 at 02:04:44PM -0700, Jarno Rajahalme wrote: > > On Oct 25, 2013, at 1:56 PM, Ben Pfaff wrote: > > > On Fri, Oct 25, 2013 at 01:44:17PM -0700, Jarno Rajahalme wrote: > >> > >> On Oct 25, 2013, at 1:32 PM, Ben Pfaff wrote: > >> > >>> On Thu, Oct 24, 2013 at 02:08:24PM -0700

Re: [ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-10-25 Thread Jarno Rajahalme
On Oct 25, 2013, at 1:56 PM, Ben Pfaff wrote: > On Fri, Oct 25, 2013 at 01:44:17PM -0700, Jarno Rajahalme wrote: >> >> On Oct 25, 2013, at 1:32 PM, Ben Pfaff wrote: >> >>> On Thu, Oct 24, 2013 at 02:08:24PM -0700, Jarno Rajahalme wrote: On Oct 21, 2013, at 3:52 PM, Ben Pfaff

Re: [ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-10-25 Thread Ben Pfaff
On Fri, Oct 25, 2013 at 01:44:17PM -0700, Jarno Rajahalme wrote: > > On Oct 25, 2013, at 1:32 PM, Ben Pfaff wrote: > > > On Thu, Oct 24, 2013 at 02:08:24PM -0700, Jarno Rajahalme wrote: > >> > >> > >> On Oct 21, 2013, at 3:52 PM, Ben Pfaff wrote: > >> > >>> Commit e3b5693319c (Fix table chec

Re: [ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-10-25 Thread Jarno Rajahalme
On Oct 25, 2013, at 1:32 PM, Ben Pfaff wrote: > On Thu, Oct 24, 2013 at 02:08:24PM -0700, Jarno Rajahalme wrote: >> >> >> On Oct 21, 2013, at 3:52 PM, Ben Pfaff wrote: >> >>> Commit e3b5693319c (Fix table checking for goto table instruction.) moved >>> action checking into modify_flows__(),

Re: [ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-10-25 Thread Ben Pfaff
On Thu, Oct 24, 2013 at 02:08:24PM -0700, Jarno Rajahalme wrote: > > > On Oct 21, 2013, at 3:52 PM, Ben Pfaff wrote: > > > Commit e3b5693319c (Fix table checking for goto table instruction.) moved > > action checking into modify_flows__(), for good reason, but as a side > > effect made modify_f

Re: [ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-10-24 Thread Jarno Rajahalme
On Oct 21, 2013, at 3:52 PM, Ben Pfaff wrote: > Commit e3b5693319c (Fix table checking for goto table instruction.) moved > action checking into modify_flows__(), for good reason, but as a side > effect made modify_flows__() abandon and never commit the ofopgroup that it > started, if action ch

[ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-10-21 Thread Ben Pfaff
Commit e3b5693319c (Fix table checking for goto table instruction.) moved action checking into modify_flows__(), for good reason, but as a side effect made modify_flows__() abandon and never commit the ofopgroup that it started, if action checking failed. This commit fixes the problem. The follow