Re: [ovs-dev] [PATCH] ofproto: Allow ofproto_delete_flow() to delete hidden rules.

2013-09-23 Thread Ben Pfaff
On Mon, Sep 23, 2013 at 09:17:32PM -0700, Justin Pettit wrote: > > On Sep 23, 2013, at 8:39 PM, Ben Pfaff wrote: > > > [resend with Luca's email address fixed] > > > > On Mon, Sep 23, 2013 at 08:35:05PM -0700, Ben Pfaff wrote: > >> Commit 97f63e57a8 (ofproto: Remove soon-to-be-invalid optimizat

Re: [ovs-dev] [PATCH] ofproto: Allow ofproto_delete_flow() to delete hidden rules.

2013-09-23 Thread Justin Pettit
On Sep 23, 2013, at 8:39 PM, Ben Pfaff wrote: > [resend with Luca's email address fixed] > > On Mon, Sep 23, 2013 at 08:35:05PM -0700, Ben Pfaff wrote: >> Commit 97f63e57a8 (ofproto: Remove soon-to-be-invalid optimizations.) >> changed ofproto_delete_flow() to use the general-purpose flow_mod >

Re: [ovs-dev] [PATCH] ofproto: Allow ofproto_delete_flow() to delete hidden rules.

2013-09-23 Thread Ben Pfaff
[resend with Luca's email address fixed] On Mon, Sep 23, 2013 at 08:35:05PM -0700, Ben Pfaff wrote: > Commit 97f63e57a8 (ofproto: Remove soon-to-be-invalid optimizations.) > changed ofproto_delete_flow() to use the general-purpose flow_mod > implementation. However, the general-purpose flow_mod n

[ovs-dev] [PATCH] ofproto: Allow ofproto_delete_flow() to delete hidden rules.

2013-09-23 Thread Ben Pfaff
Commit 97f63e57a8 (ofproto: Remove soon-to-be-invalid optimizations.) changed ofproto_delete_flow() to use the general-purpose flow_mod implementation. However, the general-purpose flow_mod never matches hidden flows, which are exactly the flows that ofproto_delete_flow()'s callers want to delete.