Re: [ovs-dev] [PATCH] ofproto: Add relaxed group_mod command ADD_OR_MOD

2016-06-05 Thread Ben Pfaff
On Sat, Jun 04, 2016 at 12:15:20AM +0200, Jan Scheurich wrote: > On Thu, 2 Jun 2016 16:03:02 -0700 > Ben Pfaff wrote: > > In the documentation, please note that this uses an Open vSwitch > > extension to OpenFlow and that it only works with Open vSwitch 2.6 or > > later. > > I'm a bit lost where

Re: [ovs-dev] [PATCH] ofproto: Add relaxed group_mod command ADD_OR_MOD

2016-06-03 Thread Jan Scheurich
On Thu, 2 Jun 2016 16:03:02 -0700 Ben Pfaff wrote: > > In the documentation, please note that this uses an Open vSwitch > extension to OpenFlow and that it only works with Open vSwitch 2.6 or > later. > I'm a bit lost where to put this information. Is there a documentation file that gathers al

Re: [ovs-dev] [PATCH] ofproto: Add relaxed group_mod command ADD_OR_MOD

2016-06-03 Thread Ben Pfaff
On Fri, Jun 03, 2016 at 05:07:39PM +0200, Jan Scheurich wrote: > Thanks for the review. Will update. > > > In some places, this is called "add_or_modify" and in other places just > > "write". I suggest using a consistent name. > > Which one would you suggest? I don't like the idea of using "writ

Re: [ovs-dev] [PATCH] ofproto: Add relaxed group_mod command ADD_OR_MOD

2016-06-03 Thread Jan Scheurich
Hi Ben, Thanks for the review. Will update. > In some places, this is called "add_or_modify" and in other places just > "write". I suggest using a consistent name. Which one would you suggest? BR, Jan ___ dev mailing list dev@openvswitch.org http://op

Re: [ovs-dev] [PATCH] ofproto: Add relaxed group_mod command ADD_OR_MOD

2016-06-02 Thread Ben Pfaff
On Sat, May 21, 2016 at 12:42:49AM +0200, Jan Scheurich wrote: > *** Reposting the patch once more. First two attempts got corrupted *** > *** Sorry, still trying to find a suitable email client *** Hi, thanks for the patch. It seems almost ready to me. I have a few comments. In some places, th

Re: [ovs-dev] [PATCH] ofproto: Add relaxed group_mod command ADD_OR_MOD

2016-05-30 Thread Jan Scheurich
Could someone perhaps have a look at the latest version of the patch? Thanks a lot, Jan On Sat, 21 May 2016 00:42:49 +0200 Jan Scheurich wrote: > *** Reposting the patch once more. First two attempts got corrupted > *** *** Sorry, still trying to find a suitable email client *** > > This patc

[ovs-dev] [PATCH] ofproto: Add relaxed group_mod command ADD_OR_MOD

2016-05-20 Thread Jan Scheurich
*** Reposting the patch once more. First two attempts got corrupted *** *** Sorry, still trying to find a suitable email client *** This patch adds support for a new Group Mod command OFPGC_ADD_OR_MOD to OVS for all OpenFlow versions supporting groups (OF11 and higher). The new ADD_OR_MOD creates

Re: [ovs-dev] [PATCH] ofproto: Add relaxed group_mod command ADD_OR_MOD

2016-05-20 Thread Jeff Feng
Incorrect patch format: patching file include/openflow/openflow-1.1.h patch: malformed patch at line 10: group. */ }; ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ofproto: Add relaxed group_mod command ADD_OR_MOD

2016-05-20 Thread Jan Scheurich
*** Reposting the patch. First attempt got corrupted *** This patch adds support for a new Group Mod command OFPGC_ADD_OR_MOD to OVS for all OpenFlow versions supporting groups (OF11 and higher). The new ADD_OR_MOD creates a group that does not yet exist (like ADD) or modifies an existing group (l

Re: [ovs-dev] [PATCH] ofproto: Add relaxed group_mod command ADD_OR_MOD

2016-05-20 Thread Ben Pfaff
On Thu, May 19, 2016 at 04:58:48PM +0200, Jan Scheurich wrote: > This patch adds support for a new Group Mod command OFPGC_ADD_OR_MOD to OVS > for all OpenFlow versions supporting groups (OF11 and higher). The new > ADD_OR_MOD creates a group that does not yet exist (like ADD) or modifies > an exis

[ovs-dev] [PATCH] ofproto: Add relaxed group_mod command ADD_OR_MOD

2016-05-19 Thread Jan Scheurich
This patch adds support for a new Group Mod command OFPGC_ADD_OR_MOD to OVS for all OpenFlow versions supporting groups (OF11 and higher). The new ADD_OR_MOD creates a group that does not yet exist (like ADD) or modifies an existing group (like MODIFY). Rational: In OpenFlow 1.x the Group Mod comm