Re: [ovs-dev] [PATCH] ofproto/trace: Fix parsing error.

2015-05-01 Thread Alex Wang
After confirming with Jacob, found that there was actually a bug in the parse_flag() function.~ Will send the bug fix~ Thanks, Alex Wang, On Thu, Apr 30, 2015 at 2:00 PM, Jarno Rajahalme wrote: > Alex, > > I think that the non-support for the mask has been deliberate, as the mask > operates on

Re: [ovs-dev] [PATCH] ofproto/trace: Fix parsing error.

2015-04-30 Thread Jarno Rajahalme
Alex, I think that the non-support for the mask has been deliberate, as the mask operates on bits, and the frag_type attribute is defined as an enum (which actually maps to individual bits so far). Maybe the problem is on the whoever produces the string to parse? Jarno > On Apr 30, 2015, at

Re: [ovs-dev] [PATCH] ofproto/trace: Fix parsing error.

2015-04-30 Thread Alex Wang
I should do that, thx~ On Thu, Apr 30, 2015 at 11:20 AM, Ben Pfaff wrote: > On Thu, Apr 30, 2015 at 09:31:22AM -0700, Alex Wang wrote: > > ofproto/trace fails to parse the 'frag' in the ipv4 field due to a > > bug in odp-util.c. This commit fixes the bug. > > > > Reported-by: Jacob Cherkas > >

Re: [ovs-dev] [PATCH] ofproto/trace: Fix parsing error.

2015-04-30 Thread Ben Pfaff
On Thu, Apr 30, 2015 at 09:31:22AM -0700, Alex Wang wrote: > ofproto/trace fails to parse the 'frag' in the ipv4 field due to a > bug in odp-util.c. This commit fixes the bug. > > Reported-by: Jacob Cherkas > Signed-off-by: Alex Wang Is it possible to add a test? __

[ovs-dev] [PATCH] ofproto/trace: Fix parsing error.

2015-04-30 Thread Alex Wang
ofproto/trace fails to parse the 'frag' in the ipv4 field due to a bug in odp-util.c. This commit fixes the bug. Reported-by: Jacob Cherkas Signed-off-by: Alex Wang --- lib/odp-util.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/odp-util.c b/lib/odp-util.c in