Re: [ovs-dev] [PATCH] ofp-util: compile group stats with visual studio

2014-04-24 Thread Andy Zhou
I sent a V2 based Ben's suggestion. On Thu, Apr 24, 2014 at 3:45 PM, Ben Pfaff wrote: > On Thu, Apr 24, 2014 at 03:41:52PM -0700, Gurucharan Shetty wrote: >> On Thu, Apr 24, 2014 at 2:48 PM, Andy Zhou wrote: >> > Visual studio does not support 0 size array within a struct, >> > but supports flex

Re: [ovs-dev] [PATCH] ofp-util: compile group stats with visual studio

2014-04-24 Thread Ben Pfaff
On Thu, Apr 24, 2014 at 03:41:52PM -0700, Gurucharan Shetty wrote: > On Thu, Apr 24, 2014 at 2:48 PM, Andy Zhou wrote: > > Visual studio does not support 0 size array within a struct, > > but supports flexible array. For example, char p[0] is not supported, > > but char p[] is O.K. GCC supports b

Re: [ovs-dev] [PATCH] ofp-util: compile group stats with visual studio

2014-04-24 Thread Gurucharan Shetty
On Thu, Apr 24, 2014 at 2:48 PM, Andy Zhou wrote: > Visual studio does not support 0 size array within a struct, > but supports flexible array. For example, char p[0] is not supported, > but char p[] is O.K. GCC supports both. > > Flexible array can not directly replace a zero sized array. > http

[ovs-dev] [PATCH] ofp-util: compile group stats with visual studio

2014-04-24 Thread Andy Zhou
Visual studio does not support 0 size array within a struct, but supports flexible array. For example, char p[0] is not supported, but char p[] is O.K. GCC supports both. Flexible array can not directly replace a zero sized array. http://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html lists the diffe