Re: [ovs-dev] [PATCH] ofp-util: Fix struct ofputil_requestforward union membership.

2015-09-18 Thread Ben Pfaff
On Tue, Sep 15, 2015 at 05:31:29PM -0700, Andy Zhou wrote: > On Thu, Sep 10, 2015 at 10:00 AM, Ben Pfaff wrote: > > 'bands' should be paired with 'meter_mod' because 'bands' may hold the > > storage for the meter's bands. ('bands' has nothing to do with > > 'group_mod'.) > > > > Reported-by: niti

Re: [ovs-dev] [PATCH] ofp-util: Fix struct ofputil_requestforward union membership.

2015-09-15 Thread Andy Zhou
On Thu, Sep 10, 2015 at 10:00 AM, Ben Pfaff wrote: > 'bands' should be paired with 'meter_mod' because 'bands' may hold the > storage for the meter's bands. ('bands' has nothing to do with > 'group_mod'.) > > Reported-by: niti Rohilla > Reported-at: http://openvswitch.org/pipermail/dev/2015-Sept

[ovs-dev] [PATCH] ofp-util: Fix struct ofputil_requestforward union membership.

2015-09-10 Thread Ben Pfaff
'bands' should be paired with 'meter_mod' because 'bands' may hold the storage for the meter's bands. ('bands' has nothing to do with 'group_mod'.) Reported-by: niti Rohilla Reported-at: http://openvswitch.org/pipermail/dev/2015-September/059847.html Signed-off-by: Ben Pfaff --- lib/ofp-util.h