hi,
thank you for review.
you are right.
i didn't notice the code in ofconn_send. thank you.
i tend to think it's nicer to have ofputil_encode_xxx
generate the complete packet, though.
background:
my code [1] uses libofproto to generate on-wire packet
and write it out to a file. thus ofconn_s
Yamamoto,
ofconn_send(), which will eventually be called for these, already does
ofpmsg_update_length() before passing the message to rconn_send(). Given this,
it seems unnecessary to make this change.
Jarno
> On Apr 6, 2015, at 11:43 PM, YAMAMOTO Takashi wrote:
>
> Signed-off-by: YAMAMOTO
Signed-off-by: YAMAMOTO Takashi
---
lib/ofp-util.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index a0da289..7035c8c 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -8760,6 +8760,7 @@ ofputil_encode_bundle_ctrl_reply(const struct ofp_header
*oh,
