Re: [ovs-dev] [PATCH] ofp-util: Clean up cookie handling.

2012-05-29 Thread Justin Pettit
On May 29, 2012, at 11:49 AM, Ben Pfaff wrote: > On Tue, May 29, 2012 at 11:46:44AM -0700, Justin Pettit wrote: >> Okay, combined with the previous comment, it now looks like this: >> >> .IP "\fBovs\-ofctl mod\-flows br0 cookie=1,action=normal\fR" >> Change all flows' cookies to 1 and change thei

Re: [ovs-dev] [PATCH] ofp-util: Clean up cookie handling.

2012-05-29 Thread Ben Pfaff
On Tue, May 29, 2012 at 11:46:44AM -0700, Justin Pettit wrote: > Okay, combined with the previous comment, it now looks like this: > > .IP "\fBovs\-ofctl mod\-flows br0 cookie=1,action=normal\fR" > Change all flows' cookies to 1 and change their actions to \fBnormal\fR. > .IP "\fBovs\-ofctl mod\-f

Re: [ovs-dev] [PATCH] ofp-util: Clean up cookie handling.

2012-05-29 Thread Justin Pettit
On May 29, 2012, at 10:34 AM, Ben Pfaff wrote: > On Fri, May 25, 2012 at 06:48:40PM -0700, Justin Pettit wrote: >> Commit e72e793 (Add ability to restrict flow mods and flow stats >> requests to cookies.) modified cookie handling. Some of its behavior >> was unintuitive and there was at least one

Re: [ovs-dev] [PATCH] ofp-util: Clean up cookie handling.

2012-05-29 Thread Ben Pfaff
On Fri, May 25, 2012 at 06:48:40PM -0700, Justin Pettit wrote: > Commit e72e793 (Add ability to restrict flow mods and flow stats > requests to cookies.) modified cookie handling. Some of its behavior > was unintuitive and there was at least one bug (described below). > Commit f66b87d (DESIGN: Doc

[ovs-dev] [PATCH] ofp-util: Clean up cookie handling.

2012-05-25 Thread Justin Pettit
Commit e72e793 (Add ability to restrict flow mods and flow stats requests to cookies.) modified cookie handling. Some of its behavior was unintuitive and there was at least one bug (described below). Commit f66b87d (DESIGN: Document uses for flow cookies.) attempted to document a clean design for

Re: [ovs-dev] [PATCH] ofp-util: Clean up cookie handling.

2012-05-25 Thread Justin Pettit
On May 21, 2012, at 4:00 PM, Ben Pfaff wrote: > "git am" says: > >Applying: ofp-util: Clean up cookie handling. >/home/blp/ovs/.git/rebase-apply/patch:189: trailing whitespace. >/* Wildcard matching of the cookie is only supported through NXM. > */ >warning: 1 line adds

Re: [ovs-dev] [PATCH] ofp-util: Clean up cookie handling.

2012-05-21 Thread Ben Pfaff
On Mon, May 21, 2012 at 11:29:47AM -0700, Justin Pettit wrote: > Commit e72e793 (Add ability to restrict flow mods and flow stats > requests to cookies.) modified cookie handling. Some of its behavior > was unintuitive there was at least one bug (described below). Commit > f66b87d (DESIGN: Docume

[ovs-dev] [PATCH] ofp-util: Clean up cookie handling.

2012-05-21 Thread Justin Pettit
Commit e72e793 (Add ability to restrict flow mods and flow stats requests to cookies.) modified cookie handling. Some of its behavior was unintuitive there was at least one bug (described below). Commit f66b87d (DESIGN: Document uses for flow cookies.) attempted document a clean design for cookie