Re: [ovs-dev] [PATCH] ofp-util: Avoid use-after-free in ofputil_encode_flow_mod().

2012-06-25 Thread Ben Pfaff
Thanks, I pushed this to master, branch-1.[567]. It didn't apply to branch-1.4. On Sun, Jun 24, 2012 at 02:42:14PM -0400, Justin Pettit wrote: > Looks good. Thanks. > > BTW, I'm planning to release 1.6.1 soon. Anything else you want to get in? > > --Justin > > > On Jun 24, 2012, at 1:34 AM,

Re: [ovs-dev] [PATCH] ofp-util: Avoid use-after-free in ofputil_encode_flow_mod().

2012-06-24 Thread Justin Pettit
Unless I'm beaten to it, I'll review it later tonight when I have more time. --Justin On Jun 24, 2012, at 3:09 PM, Ben Pfaff wrote: > There's this: >http://openvswitch.org/pipermail/dev/2012-June/018163.html > > (I haven't checked whether it needs backporting to 1.6.) > > On Sun, Jun

Re: [ovs-dev] [PATCH] ofp-util: Avoid use-after-free in ofputil_encode_flow_mod().

2012-06-24 Thread Ben Pfaff
There's this: http://openvswitch.org/pipermail/dev/2012-June/018163.html (I haven't checked whether it needs backporting to 1.6.) On Sun, Jun 24, 2012 at 02:42:14PM -0400, Justin Pettit wrote: > Looks good. Thanks. > > BTW, I'm planning to release 1.6.1 soon. Anything else you want to

Re: [ovs-dev] [PATCH] ofp-util: Avoid use-after-free in ofputil_encode_flow_mod().

2012-06-24 Thread Justin Pettit
Looks good. Thanks. BTW, I'm planning to release 1.6.1 soon. Anything else you want to get in? --Justin On Jun 24, 2012, at 1:34 AM, Ben Pfaff wrote: > nx_put_match() can reallocate the ofpbuf's data so we need to reload the > pointer. > > Found by inspection. > > Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH] ofp-util: Avoid use-after-free in ofputil_encode_flow_mod().

2012-06-23 Thread Ben Pfaff
nx_put_match() can reallocate the ofpbuf's data so we need to reload the pointer. Found by inspection. Signed-off-by: Ben Pfaff --- lib/ofp-util.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 6d820b2..cc3c9fd 100644 --- a/lib/ofp