Re: [ovs-dev] [PATCH] ofp-parse: Fix sparse warnings about comparing ofp_port_ts.

2016-09-16 Thread Ben Pfaff
On Thu, Sep 15, 2016 at 01:43:54PM -0700, Joe Stringer wrote: > On 14 September 2016 at 20:59, Ben Pfaff wrote: > > Without this, sparse complains: > > > > lib/ofp-parse.c:588:19: warning: restricted ofp_port_t degrades to > > integer > > lib/ofp-parse.c:588:31: warning: restricted ofp_po

Re: [ovs-dev] [PATCH] ofp-parse: Fix sparse warnings about comparing ofp_port_ts.

2016-09-15 Thread Joe Stringer
On 14 September 2016 at 20:59, Ben Pfaff wrote: > Without this, sparse complains: > > lib/ofp-parse.c:588:19: warning: restricted ofp_port_t degrades to integer > lib/ofp-parse.c:588:31: warning: restricted ofp_port_t degrades to integer > > This is one of the irritating bits of using spar

[ovs-dev] [PATCH] ofp-parse: Fix sparse warnings about comparing ofp_port_ts.

2016-09-14 Thread Ben Pfaff
Without this, sparse complains: lib/ofp-parse.c:588:19: warning: restricted ofp_port_t degrades to integer lib/ofp-parse.c:588:31: warning: restricted ofp_port_t degrades to integer This is one of the irritating bits of using sparse, but on the whole I think it saves us pretty often. CC: