On Mon, Jul 8, 2013 at 10:13 AM, Ben Pfaff wrote:
> > 1. Could you explain why the last case "OVSINST_OFPIT11_GOTO_TABLE" is
> > enclosed by curly bracket?
>
> It has a local variable, so the braces are necessary.
Actually, I didn't know it. Good to learn.
On Mon, Jul 8, 2013 at 10:13 AM, Ben
On Tue, Jul 02, 2013 at 04:51:45PM -0700, Alex Wang wrote:
> diff --git a/lib/meta-flow.c b/lib/meta-flow.c
> > index 0677202..e66987c 100644
> > --- a/lib/meta-flow.c
> > +++ b/lib/meta-flow.c
> > @@ -2699,21 +2699,22 @@ mf_parse_subfield__(struct mf_subfield *sf, const
> > char **sp)
> > /* Pars
On Mon, Jul 08, 2013 at 10:27:30AM -0700, Alex Wang wrote:
> On Mon, Jul 8, 2013 at 10:13 AM, Ben Pfaff wrote:
> > > Actually, I'm surprised by how few tests are modified. I'll do a scan
> > > again, after this patch is updated.
> >
> > This indicates that we have poor coverage of "negative" tests
On Mon, Jul 8, 2013 at 10:13 AM, Ben Pfaff wrote:
> > Just want to ask and make sure that there will not be multiple hits in
> the
> > if-else-if statement above, right?
>
> Multiple hits? What do you mean?
Sorry, I think I was confused that time. Now, I think it all makes sense.
On Tue, Jul 02, 2013 at 05:53:20PM -0700, Alex Wang wrote:
> On Thu, Jun 27, 2013 at 5:10 PM, Ben Pfaff wrote:
> >
> > -while (!ds_get_preprocessed_line(&s, stream)) {
> > +line_number = 0;
> > +while (!ds_get_preprocessed_line(&s, stream, &line_number)) {
> > +char *error;
> >
On Thu, Jun 27, 2013 at 5:10 PM, Ben Pfaff wrote:
>
> -while (!ds_get_preprocessed_line(&s, stream)) {
> +line_number = 0;
> +while (!ds_get_preprocessed_line(&s, stream, &line_number)) {
> +char *error;
> +
> if (*n_fms >= allocated_fms) {
> *fms = x2nrea
Hey Ben,
Have comments inline,
diff --git a/lib/meta-flow.c b/lib/meta-flow.c
> index 0677202..e66987c 100644
> --- a/lib/meta-flow.c
> +++ b/lib/meta-flow.c
> @@ -2699,21 +2699,22 @@ mf_parse_subfield__(struct mf_subfield *sf, const
> char **sp)
> /* Parses a subfield from the beginning of 's'
