Re: [ovs-dev] [PATCH] odp-util: Promote skb_mark in flow_key

2013-03-22 Thread Simon Horman
On Sat, Mar 23, 2013 at 12:24:42PM +0900, Simon Horman wrote: > On Fri, Mar 22, 2013 at 08:50:24AM -0700, Ben Pfaff wrote: > > On Fri, Mar 22, 2013 at 10:45:27PM +0900, Simon Horman wrote: > > > Re-order skb_mark in odp_flow_key_from_flow() so that it appears after the > > > in_port rather than bef

Re: [ovs-dev] [PATCH] odp-util: Promote skb_mark in flow_key

2013-03-22 Thread Simon Horman
On Fri, Mar 22, 2013 at 08:50:24AM -0700, Ben Pfaff wrote: > On Fri, Mar 22, 2013 at 10:45:27PM +0900, Simon Horman wrote: > > Re-order skb_mark in odp_flow_key_from_flow() so that it appears after the > > in_port rather than before. This is consistent with the order in > > ovs_flow_to_nlattrs(). >

Re: [ovs-dev] [PATCH] odp-util: Promote skb_mark in flow_key

2013-03-22 Thread Ben Pfaff
On Fri, Mar 22, 2013 at 10:45:27PM +0900, Simon Horman wrote: > Re-order skb_mark in odp_flow_key_from_flow() so that it appears after the > in_port rather than before. This is consistent with the order in > ovs_flow_to_nlattrs(). > > Without this change update_stats() detects all flows with a non

[ovs-dev] [PATCH] odp-util: Promote skb_mark in flow_key

2013-03-22 Thread Simon Horman
Re-order skb_mark in odp_flow_key_from_flow() so that it appears after the in_port rather than before. This is consistent with the order in ovs_flow_to_nlattrs(). Without this change update_stats() detects all flows with a non-zero skb_mark as unexpected flows as the flow key received from the ker