Re: [ovs-dev] [PATCH] nx-match: Fix use-after-free parsing matches.

2016-03-29 Thread Joe Stringer
On 23 March 2016 at 06:41, Ben Pfaff wrote: > On Mon, Mar 07, 2016 at 11:31:02AM -0800, Joe Stringer wrote: >> Address pointed by header_ptr might be free'd due to realloc >> happened in ofpbuf_put_hex(). Reported by valgrind in the test >> 379: check TCP flags expression in OXM and NXM. >> >> Inv

Re: [ovs-dev] [PATCH] nx-match: Fix use-after-free parsing matches.

2016-03-22 Thread Ben Pfaff
On Mon, Mar 07, 2016 at 11:31:02AM -0800, Joe Stringer wrote: > Address pointed by header_ptr might be free'd due to realloc > happened in ofpbuf_put_hex(). Reported by valgrind in the test > 379: check TCP flags expression in OXM and NXM. > > Invalid write of size 4 > nx_match_from_string_raw

Re: [ovs-dev] [PATCH] nx-match: Fix use-after-free parsing matches.

2016-03-07 Thread William Tu
Hi Joe, I've tested this patch (with modification to ofpbuf_put to force using newly allocated address) and it works fine. Thanks! Regards, William On Mon, Mar 7, 2016 at 11:31 AM, Joe Stringer wrote: > Address pointed by header_ptr might be free'd due to realloc > happened in ofpbuf_put_hex()

[ovs-dev] [PATCH] nx-match: Fix use-after-free parsing matches.

2016-03-07 Thread Joe Stringer
Address pointed by header_ptr might be free'd due to realloc happened in ofpbuf_put_hex(). Reported by valgrind in the test 379: check TCP flags expression in OXM and NXM. Invalid write of size 4 nx_match_from_string_raw (nx-match.c:1510) nx_match_from_string (nx-match.c:1538) ofctl_pa