Re: [ovs-dev] [PATCH] nf_nat_packet: Clear skb hash after modifying packet headers.

2016-04-30 Thread Florian Westphal
Jarno Rajahalme wrote: > In the OVS datapath we clear the skb hash whenever we change any of the > fields that may be used to compute it. This guarantees that any given flow > will get the same hash value when assigning packets to bond interfaces based > on the skb hash. If the hash is not clea

Re: [ovs-dev] [PATCH] nf_nat_packet: Clear skb hash after modifying packet headers.

2016-04-29 Thread Jarno Rajahalme
> On Apr 29, 2016, at 2:12 AM, Florian Westphal wrote: > > Pablo Neira Ayuso mailto:pa...@netfilter.org>> wrote: >> On Wed, Apr 20, 2016 at 02:31:10PM -0700, Jarno Rajahalme wrote: >>> Clear the skb hash when it does not reflect the actual header values >>> any more. >>> >>> Signed-off-by: Jarn

Re: [ovs-dev] [PATCH] nf_nat_packet: Clear skb hash after modifying packet headers.

2016-04-29 Thread Florian Westphal
Pablo Neira Ayuso wrote: > On Wed, Apr 20, 2016 at 02:31:10PM -0700, Jarno Rajahalme wrote: > > Clear the skb hash when it does not reflect the actual header values > > any more. > > > > Signed-off-by: Jarno Rajahalme > > --- > > net/netfilter/nf_nat_core.c | 1 + > > 1 file changed, 1 insertio

Re: [ovs-dev] [PATCH] nf_nat_packet: Clear skb hash after modifying packet headers.

2016-04-29 Thread Pablo Neira Ayuso
On Wed, Apr 20, 2016 at 02:31:10PM -0700, Jarno Rajahalme wrote: > Clear the skb hash when it does not reflect the actual header values > any more. > > Signed-off-by: Jarno Rajahalme > --- > net/netfilter/nf_nat_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/netfilter/nf_na

[ovs-dev] [PATCH] nf_nat_packet: Clear skb hash after modifying packet headers.

2016-04-20 Thread Jarno Rajahalme
Clear the skb hash when it does not reflect the actual header values any more. Signed-off-by: Jarno Rajahalme --- net/netfilter/nf_nat_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/nf_nat_core.c b/net/netfilter/nf_nat_core.c index 06a9f45..3c2302f 100644 --- a/net/netf