Re: [ovs-dev] [PATCH] netdev-dummy: Count rx packets regardless of source

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 11:44:57AM +0300, Lori Jakab wrote: > FAIL: detailed_contr_sw_messages.DeleteEmerFlow > FAIL: message_types.QueueConfigReply Without looking at the tests, I guess that these are probably both genuine failures. OVS has never implemented the emergency flow cache, and likely

Re: [ovs-dev] [PATCH] netdev-dummy: Count rx packets regardless of source

2013-10-17 Thread Lori Jakab
On 10/17/13 3:23 AM, Simon Horman wrote: On Wed, Oct 16, 2013 at 02:32:55PM +0300, Lori Jakab wrote: On 10/16/13 1:17 PM, Simon Horman wrote: This alters the way rx packets are accounted for by counting them when they are processed by netdev_dummy_rx_recv(), which seems to be a common path used

Re: [ovs-dev] [PATCH] netdev-dummy: Count rx packets regardless of source

2013-10-16 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 09:54:11AM +0900, Simon Horman wrote: > I did wonder if this solution is slightly sub-optimal as > now the mutex is taken both in netdev_dummy_rx_recv() > and netdev_dummy_rx_recv(). Then again, I'm not sure that > it is critical to optimise netdev-dummy. I agree, netdev-du

Re: [ovs-dev] [PATCH] netdev-dummy: Count rx packets regardless of source

2013-10-16 Thread Simon Horman
On Wed, Oct 16, 2013 at 09:09:15AM -0700, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 07:17:01PM +0900, Simon Horman wrote: > > This alters the way rx packets are accounted for by > > counting them when they are processed by netdev_dummy_rx_recv(), > > which seems to be a common path used by all rec

Re: [ovs-dev] [PATCH] netdev-dummy: Count rx packets regardless of source

2013-10-16 Thread Simon Horman
On Wed, Oct 16, 2013 at 02:32:55PM +0300, Lori Jakab wrote: > On 10/16/13 1:17 PM, Simon Horman wrote: > >This alters the way rx packets are accounted for by > >counting them when they are processed by netdev_dummy_rx_recv(), > >which seems to be a common path used by all received packets. > > > >P

Re: [ovs-dev] [PATCH] netdev-dummy: Count rx packets regardless of source

2013-10-16 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 02:32:55PM +0300, Lori Jakab wrote: > On 10/16/13 1:17 PM, Simon Horman wrote: > >This alters the way rx packets are accounted for by > >counting them when they are processed by netdev_dummy_rx_recv(), > >which seems to be a common path used by all received packets. > > > >P

Re: [ovs-dev] [PATCH] netdev-dummy: Count rx packets regardless of source

2013-10-16 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 07:17:01PM +0900, Simon Horman wrote: > This alters the way rx packets are accounted for by > counting them when they are processed by netdev_dummy_rx_recv(), > which seems to be a common path used by all received packets. > > Previously accounting was done earlier, in netd

Re: [ovs-dev] [PATCH] netdev-dummy: Count rx packets regardless of source

2013-10-16 Thread Lori Jakab
On 10/16/13 1:17 PM, Simon Horman wrote: This alters the way rx packets are accounted for by counting them when they are processed by netdev_dummy_rx_recv(), which seems to be a common path used by all received packets. Previously accounting was done earlier, in netdev_dummy_receive(), however t

[ovs-dev] [PATCH] netdev-dummy: Count rx packets regardless of source

2013-10-16 Thread Simon Horman
This alters the way rx packets are accounted for by counting them when they are processed by netdev_dummy_rx_recv(), which seems to be a common path used by all received packets. Previously accounting was done earlier, in netdev_dummy_receive(), however this does not appear to count packets that a