On Wed, Jun 25, 2014 at 10:48:41AM +, Tahhan, Maryam wrote:
> Thanks for the feedback, I will refactor and resubmit, just a
> question regarding the section that sets the MAC address for the
> logical vhost port, is the issue just the formatting you mention
> after the comment about it being wr
d, ETH_ADDR_ARGS(eth_addr.addr_bytes));
or deleting altogether, what do you recommend?
Regards
Maryam
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Tuesday, June 24, 2014 5:04 PM
To: Tahhan, Maryam
Cc: dev@openvswitch.org; Rogers, Gerald
Subject: Re: [ovs-dev] [PATCH]
On Fri, Jun 20, 2014 at 04:23:48PM +0100, maryam.tahhan wrote:
> From: "maryam.tahhan"
>
> This patch enables arbitrary port naming for vhost patches, so
> they no longer need to be called dpdkvhost.
>
> Signed-off-by: maryam.tahhan
Oh, also the subject should be:
[PATCH] netdev-dpdk:
On Fri, Jun 20, 2014 at 04:23:48PM +0100, maryam.tahhan wrote:
> From: "maryam.tahhan"
>
> This patch enables arbitrary port naming for vhost patches, so
> they no longer need to be called dpdkvhost.
>
> Signed-off-by: maryam.tahhan
This is not a substantive review, but I do have a few comment
From: "maryam.tahhan"
This patch enables arbitrary port naming for vhost patches, so
they no longer need to be called dpdkvhost.
Signed-off-by: maryam.tahhan
---
INSTALL.DPDK | 6 +++---
lib/netdev-dpdk.c | 30 --
2 files changed, 19 insertions(+), 17 deletion
