Re: [ovs-dev] [PATCH] netdev: New function netdev_ref().

2013-05-22 Thread Ben Pfaff
Applied to master, thanks. On Wed, May 22, 2013 at 10:42:32AM -0700, Ethan Jackson wrote: > LGTM as well. I plan to use this in the CFM patch so please go ahead > and push it. > > Ethan > > On Wed, May 22, 2013 at 8:50 AM, Ben Pfaff wrote: > > Thanks for taking a look. I won't push this unles

Re: [ovs-dev] [PATCH] netdev: New function netdev_ref().

2013-05-22 Thread Ethan Jackson
LGTM as well. I plan to use this in the CFM patch so please go ahead and push it. Ethan On Wed, May 22, 2013 at 8:50 AM, Ben Pfaff wrote: > Thanks for taking a look. I won't push this unless Ethan says that he > thinks it is useful for his recent cfm patch. > > I have two perspectives on your

Re: [ovs-dev] [PATCH] netdev: New function netdev_ref().

2013-05-22 Thread Ben Pfaff
Thanks for taking a look. I won't push this unless Ethan says that he thinks it is useful for his recent cfm patch. I have two perspectives on your question. The first one is that this situation is analogous to strchr(), which takes a const char * and returns a char *. Its parameter is const be

Re: [ovs-dev] [PATCH] netdev: New function netdev_ref().

2013-05-21 Thread Alex Wang
Looks good to me. Want to ask what is the tradeoff between using "const struct netdev" and "struct netdev" as input argument. Thanks, On Tue, May 21, 2013 at 3:42 PM, Ben Pfaff wrote: > I suspect that this makes it easier to make sure that a netdev stays open > as long as needed in some cases w

[ovs-dev] [PATCH] netdev: New function netdev_ref().

2013-05-21 Thread Ben Pfaff
I suspect that this makes it easier to make sure that a netdev stays open as long as needed in some cases where a module needs access to a netdev opened by some higher-level module. CC: Ethan Jackson Signed-off-by: Ben Pfaff --- lib/netdev.c | 11 +++ lib/netdev.h |1 + 2 files ch