Re: [ovs-dev] [PATCH] lib: simplify flow_extract() API

2014-02-28 Thread Andy Zhou
Pushed to the master with the changes suggested. On Thu, Feb 27, 2014 at 3:21 PM, Jarno Rajahalme wrote: > I like this, some comments below, otherwise: > > Acked-by: Jarno Rajahalme > > On Feb 26, 2014, at 6:22 PM, Andy Zhou wrote: > > > Change the flow_extract() API to accept struct pkt_metad

Re: [ovs-dev] [PATCH] lib: simplify flow_extract() API

2014-02-27 Thread Jarno Rajahalme
I like this, some comments below, otherwise: Acked-by: Jarno Rajahalme On Feb 26, 2014, at 6:22 PM, Andy Zhou wrote: > Change the flow_extract() API to accept struct pkt_metadta, > instead of individual metadata fields. It will make the API more > logical and easier to maintain when we need to

Re: [ovs-dev] [PATCH] lib: simplify flow_extract() API

2014-02-26 Thread Ben Pfaff
On Wed, Feb 26, 2014 at 06:22:39PM -0800, Andy Zhou wrote: > Change the flow_extract() API to accept struct pkt_metadta, > instead of individual metadata fields. It will make the API more > logical and easier to maintain when we need to expand metadata > down the road. > > Signed-off-by: Andy Zhou

[ovs-dev] [PATCH] lib: simplify flow_extract() API

2014-02-26 Thread Andy Zhou
Change the flow_extract() API to accept struct pkt_metadta, instead of individual metadata fields. It will make the API more logical and easier to maintain when we need to expand metadata down the road. Signed-off-by: Andy Zhou --- lib/dpif-netdev.c |6 ++ lib/flow.c