Re: [ovs-dev] [PATCH] lib: refactor match_format() output functions

2013-12-04 Thread Andy Zhou
Thanks. Pushed to the master with %#"PRIx32" as suggested. On Wed, Dec 4, 2013 at 7:57 AM, Ben Pfaff wrote: > On Wed, Dec 04, 2013 at 12:39:49AM -0800, Andy Zhou wrote: > > Refactor to remove some duplicated logic in match_format() > > implemenation and make the output more uniform. > > > > Sig

Re: [ovs-dev] [PATCH] lib: refactor match_format() output functions

2013-12-04 Thread Ben Pfaff
On Wed, Dec 04, 2013 at 12:39:49AM -0800, Andy Zhou wrote: > Refactor to remove some duplicated logic in match_format() > implemenation and make the output more uniform. > > Signed-off-by: Andy Zhou I would just use %#"PRIx32" instead of the logic that prints the 0x only if the output is more th

[ovs-dev] [PATCH] lib: refactor match_format() output functions

2013-12-04 Thread Andy Zhou
Refactor to remove some duplicated logic in match_format() implemenation and make the output more uniform. Signed-off-by: Andy Zhou --- lib/dynamic-string.h |8 + lib/match.c | 84 +++-- tests/ofproto-dpif.at |6 ++-- 3 files c