Re: [ovs-dev] [PATCH] lib: Remove extra API dependency for ovs_thread_create()

2016-07-05 Thread Andy Zhou
On Fri, Jul 1, 2016 at 8:15 PM, Ben Pfaff wrote: > On Fri, Jun 17, 2016 at 04:25:32PM -0700, Andy Zhou wrote: > > When calling ovs_thread_create() without calling fatal_signal_init() > > first, ovs_thread_create() some times asserts. This dependency is > > subtle and not very obvious. > > > > The

Re: [ovs-dev] [PATCH] lib: Remove extra API dependency for ovs_thread_create()

2016-07-01 Thread Ben Pfaff
On Fri, Jun 17, 2016 at 04:25:32PM -0700, Andy Zhou wrote: > When calling ovs_thread_create() without calling fatal_signal_init() > first, ovs_thread_create() some times asserts. This dependency is > subtle and not very obvious. > > The root cause seems to be that, within ovs_thread_create(), the

[ovs-dev] [PATCH] lib: Remove extra API dependency for ovs_thread_create()

2016-06-17 Thread Andy Zhou
When calling ovs_thread_create() without calling fatal_signal_init() first, ovs_thread_create() some times asserts. This dependency is subtle and not very obvious. The root cause seems to be that, within ovs_thread_create(), the multi-threaded state is declared before all initializations are done.