Re: [ovs-dev] [PATCH] lib/util.h: use types compatible with DWORD

2015-02-11 Thread Gurucharan Shetty
On Tue, Feb 10, 2015 at 4:38 PM, Nithin Raju wrote: > _BitScanForward() and friends are part of the Windows API and > take DWORD as parameter type. DWORD is defined to be 'unsigned long' > in Windows' header files. > > We call into these functions from within lib/util.h. Currently, we > pass argum

[ovs-dev] [PATCH] lib/util.h: use types compatible with DWORD

2015-02-11 Thread Nithin Raju
_BitScanForward() and friends are part of the Windows API and take DWORD as parameter type. DWORD is defined to be 'unsigned long' in Windows' header files. We call into these functions from within lib/util.h. Currently, we pass arguments of type uint32_t which is type defined to 'unsigned int'. T

Re: [ovs-dev] [PATCH] lib/util.h: use types compatible with DWORD

2015-02-11 Thread Nithin Raju
Unit tests pass except for 3 failures. 2 of them seem expected, and the third one is with running ovsdb-server.exe as a Windows service. This does not seem to be related to my change, and the failure seen without my change as well. I’ll debug that as a separate issue. thanks, — Nithin > On Feb

Re: [ovs-dev] [PATCH] lib/util.h: use types compatible with DWORD

2015-02-11 Thread Nithin Raju
Caveat: Unit tests are running and not complete yet. I’ll reply back once they are complete. thanks, -- Nithin > On Feb 10, 2015, at 4:38 PM, Nithin Raju wrote: > > _BitScanForward() and friends are part of the Windows API and > take DWORD as parameter type. DWORD is defined to be 'unsigned lo