Re: [ovs-dev] [PATCH] lib/util: Only define count_1bits_8 when needed.

2013-12-11 Thread Jarno Rajahalme
Ben, I like this, I’ll post a new patch ASAP, Jarno On Dec 11, 2013, at 11:33 AM, Ben Pfaff wrote: > On Wed, Dec 11, 2013 at 10:54:00AM -0800, Jarno Rajahalme wrote: >> util.h declares this when needed, make sure the definition is compiled >> in only in that case. >> >> Signed-off-by: Jarno

Re: [ovs-dev] [PATCH] lib/util: Only define count_1bits_8 when needed.

2013-12-11 Thread Ben Pfaff
On Wed, Dec 11, 2013 at 10:54:00AM -0800, Jarno Rajahalme wrote: > util.h declares this when needed, make sure the definition is compiled > in only in that case. > > Signed-off-by: Jarno Rajahalme With this, I still get: ../lib/util.c:921:15: warning: symbol 'count_1bits_8' was not decla

[ovs-dev] [PATCH] lib/util: Only define count_1bits_8 when needed.

2013-12-11 Thread Jarno Rajahalme
util.h declares this when needed, make sure the definition is compiled in only in that case. Signed-off-by: Jarno Rajahalme --- lib/util.c |2 +- lib/util.h | 18 -- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/lib/util.c b/lib/util.c index 13d41a7..00050