I don't recall if we arrived at a decision about this.
Daniele
2014-11-24 15:02 GMT+01:00 Daniele Venturino :
>
> commit bacdb85ad82f981697245eefb40a3b360cfe379b
>> Author: Alex Wang
>> Date: Tue Jul 15 18:52:19 2014 -0700
>> stp: Make stp-disabled port forward stp bpdu packets.
>> Co
commit bacdb85ad82f981697245eefb40a3b360cfe379b
Author: Alex Wang mailto:al...@nicira.com>>
Date: Tue Jul 15 18:52:19 2014 -0700
stp: Make stp-disabled port forward stp bpdu packets.
Commit 0d1cee123a84 (stp: Fix bpdu tx problem in listening state)
makes ovs drop the stp bpdu packets
Now that there is a difference between non-configured STP/RSTP and disabled
STP/RSTP the situation may be different.
If they still after this patch (considering the recent changes) will always
return a fixed value, then yes.
You should consider how the calling sites use these functions, as some
We didn’t merge this patch back in september.
Were you suggesting to remove both stp_should_forward_bpdu() and
rstp_should_manage_bpdu() ?
Regards,
Daniele
> Il giorno 11/set/2014, alle ore 16:11, Jarno Rajahalme
> ha scritto:
>
>
>
> Sent from my iPhone
>
> On Sep 11, 2014, at 2:08 AM, Da
Sent from my iPhone
> On Sep 11, 2014, at 2:08 AM, Daniele Venturino
> wrote:
>
>
>> Il giorno 10/set/2014, alle ore 18:54, Jarno Rajahalme
>> ha scritto:
>>
>> Daniele,
>>
>> See comments below.
>>
>> Also, it would be preferable to send related changes, or multiple unrelated
>> chang
Il giorno 10/set/2014, alle ore 18:54, Jarno Rajahalme
ha scritto:
> Daniele,
>
> See comments below.
>
> Also, it would be preferable to send related changes, or multiple unrelated
> changes to any given subsystem, as a series of patches instead of individual
> ones. “git format-patch” doe
Daniele,
See comments below.
Also, it would be preferable to send related changes, or multiple unrelated
changes to any given subsystem, as a series of patches instead of individual
ones. “git format-patch” does that automatically.
Jarno
On Sep 10, 2014, at 1:28 AM, Daniele Venturino wrote
See commit bacdb85ad82f981697245eefb40a3b360cfe379b.
Signed-off by: Daniele Venturino
---
lib/rstp.h | 42 +++---
ofproto/ofproto-dpif-xlate.c | 6 +++---
2 files changed, 42 insertions(+), 6 deletions(-)
diff --git a/lib/rstp.h b/lib/rs
