Re: [ovs-dev] [PATCH] lib/odp: coverity null check in odp_execute_sample

2014-08-27 Thread Ben Pfaff
On Tue, Aug 26, 2014 at 06:00:42PM -0700, Madhu Challa wrote: > call odp_execute_actions__ only if there are any subactions to prevent null > pointer dereference in nl_attr_get(). > > Signed-off-by: Madhu Challa Should not be necessary because we don't generally deal with untrusted ODP actions i

Re: [ovs-dev] [PATCH] lib/odp: coverity null check in odp_execute_sample

2014-08-27 Thread Thomas Graf
On 08/26/14 at 06:00pm, Madhu Challa wrote: > call odp_execute_actions__ only if there are any subactions to prevent null > pointer dereference in nl_attr_get(). > > Signed-off-by: Madhu Challa > --- > lib/odp-execute.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/odp-exec

[ovs-dev] [PATCH] lib/odp: coverity null check in odp_execute_sample

2014-08-26 Thread Madhu Challa
call odp_execute_actions__ only if there are any subactions to prevent null pointer dereference in nl_attr_get(). Signed-off-by: Madhu Challa --- lib/odp-execute.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/odp-execute.c b/lib/odp-execute.c index e1e9b57..607af03 100644 --- a/