Re: [ovs-dev] [PATCH] lib/lockfile.c: Fix the name of the lockfile on Windows

2014-07-26 Thread Ben Pfaff
On Fri, Jul 25, 2014 at 07:27:58PM -0700, Nithin Raju wrote: > On Windows, backslash('\') is a valid directory separator. In > lockfile_name(), we treat only forward-slash ('/') as a directory > separator. This results in a lockfile name such as > ...\conf.db.~lock~ for a input file such as ..\conf

[ovs-dev] [PATCH] lib/lockfile.c: Fix the name of the lockfile on Windows

2014-07-25 Thread Nithin Raju
On Windows, backslash('\') is a valid directory separator. In lockfile_name(), we treat only forward-slash ('/') as a directory separator. This results in a lockfile name such as ...\conf.db.~lock~ for a input file such as ..\conf.db. We fix the issue in this patch. This was per Ben's suggestion.

Re: [ovs-dev] [PATCH] lib/lockfile.c: Fix the name of the lockfile on Windows

2014-07-24 Thread Ben Pfaff
On Thu, Jul 24, 2014 at 11:46:07AM -0700, Nithin Raju wrote: > On Windows, for a filename such as ..\conf.db, the name of the lockfile > constructed by lockfile_name() turns out to be ...\conf.db.~lock~. This is > not a valid path. The extra '.' added to make the file hidden does not work > as exp

[ovs-dev] [PATCH] lib/lockfile.c: Fix the name of the lockfile on Windows

2014-07-24 Thread Nithin Raju
On Windows, for a filename such as ..\conf.db, the name of the lockfile constructed by lockfile_name() turns out to be ...\conf.db.~lock~. This is not a valid path. The extra '.' added to make the file hidden does not work as expected if backslash ('\') is used for directory separation. A simple