Re: [ovs-dev] [PATCH] lib/flow: Always zero init before use.

2013-10-17 Thread Jarno Rajahalme
On Oct 11, 2013, at 4:45 PM, Ben Pfaff wrote: > > I mean that Justin says it isn't necessary to match on everything, so > that we could easily get rid of the call to > flow_wildcards_init_exact(). This turned out to be a bit more work than I expected. I just sent a new patch ("[PATCH v4] More

Re: [ovs-dev] [PATCH] lib/flow: Always zero init before use.

2013-10-11 Thread Ben Pfaff
On Fri, Oct 11, 2013 at 04:40:38PM -0700, Jarno Rajahalme wrote: > > On Oct 11, 2013, at 1:36 PM, Ben Pfaff wrote: > > > >> On Fri, Oct 11, 2013 at 12:51:35PM -0700, Jarno Rajahalme wrote: > >> > >>> On Oct 11, 2013, at 9:02 AM, Ben Pfaff wrote: > >>> > On Wed, Oct 09, 2013 at 01:47:50PM

Re: [ovs-dev] [PATCH] lib/flow: Always zero init before use.

2013-10-11 Thread Jarno Rajahalme
> On Oct 11, 2013, at 1:36 PM, Ben Pfaff wrote: > >> On Fri, Oct 11, 2013 at 12:51:35PM -0700, Jarno Rajahalme wrote: >> >>> On Oct 11, 2013, at 9:02 AM, Ben Pfaff wrote: >>> On Wed, Oct 09, 2013 at 01:47:50PM -0700, Jarno Rajahalme wrote: Use the offset of the last member in struct

Re: [ovs-dev] [PATCH] lib/flow: Always zero init before use.

2013-10-11 Thread Ben Pfaff
On Fri, Oct 11, 2013 at 12:51:35PM -0700, Jarno Rajahalme wrote: > > On Oct 11, 2013, at 9:02 AM, Ben Pfaff wrote: > > > On Wed, Oct 09, 2013 at 01:47:50PM -0700, Jarno Rajahalme wrote: > >> Use the offset of the last member in struct flow instead of the > >> struct size to help catch changes in

Re: [ovs-dev] [PATCH] lib/flow: Always zero init before use.

2013-10-11 Thread Jarno Rajahalme
On Oct 11, 2013, at 9:02 AM, Ben Pfaff wrote: > On Wed, Oct 09, 2013 at 01:47:50PM -0700, Jarno Rajahalme wrote: >> Use the offset of the last member in struct flow instead of the >> struct size to help catch changes in the declaration. >> >> Add flow_random_hash_fields() used for testing in pl

Re: [ovs-dev] [PATCH] lib/flow: Always zero init before use.

2013-10-11 Thread Ben Pfaff
On Wed, Oct 09, 2013 at 01:47:50PM -0700, Jarno Rajahalme wrote: > Use the offset of the last member in struct flow instead of the > struct size to help catch changes in the declaration. > > Add flow_random_hash_fields() used for testing in places where > struct flow was used without zero initiali

[ovs-dev] [PATCH] lib/flow: Always zero init before use.

2013-10-09 Thread Jarno Rajahalme
Use the offset of the last member in struct flow instead of the struct size to help catch changes in the declaration. Add flow_random_hash_fields() used for testing in places where struct flow was used without zero initialization before. With these changes we do not need to keep updating explicit