Re: [ovs-dev] [PATCH] lib/dpif-netdev.c: Remove redundant call to flow_extract

2013-05-23 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On May 23, 2013, at 21:21 , ext Alex Wang wrote: Hey Ben, Just found, I think there are cases that a whole packet is wanted. In function "dp_netdev_execute_actions()", there are calls to functions like "push_mpls()" and "pop__mpls()", which requires the packet header pointers (e.g. l2_5, l2 )

Re: [ovs-dev] [PATCH] lib/dpif-netdev.c: Remove redundant call to flow_extract

2013-05-23 Thread Alex Wang
Hey Ben, Just found, I think there are cases that a whole packet is wanted. In function "dp_netdev_execute_actions()", there are calls to functions like "push_mpls()" and "pop__mpls()", which requires the packet header pointers (e.g. l2_5, l2 ) in "struct ofpbuf *" be initialized. I think the cal

Re: [ovs-dev] [PATCH] lib/dpif-netdev.c: Remove redundant call to flow_extract

2013-05-23 Thread Ben Pfaff
On Tue, May 21, 2013 at 11:33:58AM -0700, Alex Wang wrote: > This commit removes the redundant call to flow_extract in dpif_netdev_execute, > since in the next line, the call to dpif_netdev_flow_from_nlattrs will reset > the flow variable. > > Signed-off-by: Alex Wang I think that the flow_extra

[ovs-dev] [PATCH] lib/dpif-netdev.c: Remove redundant call to flow_extract

2013-05-21 Thread Alex Wang
This commit removes the redundant call to flow_extract in dpif_netdev_execute, since in the next line, the call to dpif_netdev_flow_from_nlattrs will reset the flow variable. Signed-off-by: Alex Wang --- lib/dpif-netdev.c |1 - 1 file changed, 1 deletion(-) diff --git a/lib/dpif-netdev.c b/