Re: [ovs-dev] [PATCH] lib/dpif-netdev: Fix EMC lookup.

2014-10-17 Thread Jarno Rajahalme
Pushed, thanks for the review! Jarno On Oct 17, 2014, at 4:05 PM, Daniele Di Proietto wrote: > Thanks for fixing this Jarno! > > I've tested the patch and it fixes the problem. > Would you mind adding a comment on struct netdev_flow_key that 'len' > accounts for the length of the miniflow on

Re: [ovs-dev] [PATCH] lib/dpif-netdev: Fix EMC lookup.

2014-10-17 Thread Daniele Di Proietto
Thanks for fixing this Jarno! I've tested the patch and it fixes the problem. Would you mind adding a comment on struct netdev_flow_key that 'len' accounts for the length of the miniflow only (including the map)? Other comments inline, otherwise: Acked-by: Daniele Di Proietto On 10/17/14, 3:05

[ovs-dev] [PATCH] lib/dpif-netdev: Fix EMC lookup.

2014-10-17 Thread Jarno Rajahalme
Patch 0de8783a9 (lib/dpif-netdev: Integrate megaflow classifier.) broke exact match cache lookup, but it went undetected since there are no separate stats for EMC. This patch fixes the problem by changing the struct netdev_flow_key 'len' member to cover only the 'mf' member, not the whole netdev_f