Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Kyle Upton
On the master branch, it appears my change wasn't necessary. I had merged 4249b54 and run into the problem. However, 10 pushes later, 3d8dede seems to have fixed the problem without my change. Sorry about that. Thanks, Kyle On 07/20/2015 03:11 PM, Kyle Upton wrote: > Without the change, I se

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 01:13:08PM -0700, Alex Wang wrote: > Yeah, this fixes the issue, > > Do you want to push it? I sent a proper patch: http://openvswitch.org/pipermail/dev/2015-July/057798.html ___ dev mailing list dev@openvswitch.org http:

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Alex Wang
Yeah, this fixes the issue, Do you want to push it? Thanks, Alex Wang, On Mon, Jul 20, 2015 at 1:07 PM, Ben Pfaff wrote: > OK, I think I see the problem then, can you try this? > > diff --git a/lib/automake.mk b/lib/automake.mk > index fdc518e..bd23ef7 100644 > --- a/lib/automake.mk > +++ b/li

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Ben Pfaff
OK, I think I see the problem then, can you try this? diff --git a/lib/automake.mk b/lib/automake.mk index fdc518e..bd23ef7 100644 --- a/lib/automake.mk +++ b/lib/automake.mk @@ -486,14 +486,14 @@ $(srcdir)/lib/ofp-errors.inc: \ $(srcdir)/lib/ofp-errors.h \ $(srcdir

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Alex Wang
Also, here is the compilation error, while running `fakeroot debian/rules binary DEB_BUILD_OPTIONS='parallel=8 nocheck'` using ovs branch-2.4: libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I ../include -I ./include -I ../lib -I ./lib -I/usr/include -D_FORTIFY_SOURCE=2 -Wstrict-p roto

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Alex Wang
Sorry for the unclarity, I'm building branch-2.4. Master is fine, Thanks, Alex Wang, On Mon, Jul 20, 2015 at 12:11 PM, Kyle Upton wrote: > Without the change, I see the following while doing a build in our > modified version of ovs. The input source file is lib/ofp-errors.c instead > of ../lib

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Kyle Upton
Without the change, I see the following while doing a build in our modified version of ovs. The input source file is lib/ofp-errors.c instead of ../lib/ofp-errors.c. Same thing occurs with ofp-msgs.c. With the change, I don't see this issue and my thinking was that the object and not the sourc

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Ben Pfaff
OK, now I need an explanation myself. The Debian builds worked fine for me both before and after this patch. What problem do you see? On Mon, Jul 20, 2015 at 11:17:41AM -0700, Alex Wang wrote: > Could I get an explanation on why there is a typo. > > This is breaking debian build on my setup, >

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Alex Wang
Could I get an explanation on why there is a typo. This is breaking debian build on my setup, Thanks, Alex Wang, On Tue, Jul 14, 2015 at 10:43 PM, Ben Pfaff wrote: > On Thu, Jul 09, 2015 at 03:22:46PM -0400, Kyle Upton wrote: > > Fix dependency issues with lib/ofp-errors.lo and lib/ofp-msgs.lo

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-14 Thread Ben Pfaff
On Thu, Jul 09, 2015 at 03:22:46PM -0400, Kyle Upton wrote: > Fix dependency issues with lib/ofp-errors.lo and lib/ofp-msgs.lo that > caused problems when building debian packages. > > Signed-off-by: Kyle Upton Thanks, applied to master and backported to branch-2.4 and branch-2.3. __

[ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-09 Thread Kyle Upton
Fix dependency issues with lib/ofp-errors.lo and lib/ofp-msgs.lo that caused problems when building debian packages. Signed-off-by: Kyle Upton --- lib/automake.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/automake.mk b/lib/automake.mk index f72eb32..fe40e4a 100