Re: [ovs-dev] [PATCH] learn: Fix iteration over learning specs.

2016-09-02 Thread Ben Pfaff
Thanks, applied to master and branch-2.6. On Fri, Sep 02, 2016 at 03:49:59PM -0700, Jarno Rajahalme wrote: > Good catch (== thanks for finding an embarrassing bug to mine :-) > > Acked-by: Jarno Rajahalme > > > On Sep 2, 2016, at 1:26 PM, Ben Pfaff wrote: > > > > struct ofpact_learn_spec is v

Re: [ovs-dev] [PATCH] learn: Fix iteration over learning specs.

2016-09-02 Thread Jarno Rajahalme
Good catch (== thanks for finding an embarrassing bug to mine :-) Acked-by: Jarno Rajahalme > On Sep 2, 2016, at 1:26 PM, Ben Pfaff wrote: > > struct ofpact_learn_spec is variable-length. The 'n_specs' member of > struct ofpact_learn counted the number of specs, but the iteration loops > over

[ovs-dev] [PATCH] learn: Fix iteration over learning specs.

2016-09-02 Thread Ben Pfaff
struct ofpact_learn_spec is variable-length. The 'n_specs' member of struct ofpact_learn counted the number of specs, but the iteration loops over struct ofpact_learn_spec only iterated as far as the *minimum* length of 'n_specs' specs. This fixes the problem, which exhibited as consistent failur