Re: [ovs-dev] [PATCH] learn: Fix buffer overflow in parsing "learn" action strings.

2015-05-29 Thread Alex Wang
Thx a lot for the explanation, Really intrigued me a lot~! spent time writing simple example and gdb monitor it. Now understand what you mean~ Thanks, Alex Wang, On Fri, May 29, 2015 at 3:15 PM, Ben Pfaff wrote: > On Fri, May 29, 2015 at 02:51:42PM -0700, Jesse Gross wrote: > > On Fri, May 2

Re: [ovs-dev] [PATCH] learn: Fix buffer overflow in parsing "learn" action strings.

2015-05-29 Thread Ben Pfaff
On Fri, May 29, 2015 at 02:51:42PM -0700, Jesse Gross wrote: > On Fri, May 29, 2015 at 10:40 AM, Ben Pfaff wrote: > > On Wed, Feb 25, 2015 at 09:12:38AM -0800, Ben Pfaff wrote: > >> Don't panic, this is not a remote buffer overflow, only a bug in a program > >> parsing its input from the command l

Re: [ovs-dev] [PATCH] learn: Fix buffer overflow in parsing "learn" action strings.

2015-05-29 Thread Jesse Gross
On Fri, May 29, 2015 at 10:40 AM, Ben Pfaff wrote: > On Wed, Feb 25, 2015 at 09:12:38AM -0800, Ben Pfaff wrote: >> Don't panic, this is not a remote buffer overflow, only a bug in a program >> parsing its input from the command line or a file. >> >> Found by inspection. >> >> Signed-off-by: Ben Pf

Re: [ovs-dev] [PATCH] learn: Fix buffer overflow in parsing "learn" action strings.

2015-05-29 Thread Alex Wang
Acked-by: Alex Wang On Fri, May 29, 2015 at 10:40 AM, Ben Pfaff wrote: > On Wed, Feb 25, 2015 at 09:12:38AM -0800, Ben Pfaff wrote: > > Don't panic, this is not a remote buffer overflow, only a bug in a > program > > parsing its input from the command line or a file. > > > > Found by inspection

Re: [ovs-dev] [PATCH] learn: Fix buffer overflow in parsing "learn" action strings.

2015-05-29 Thread Ben Pfaff
On Wed, Feb 25, 2015 at 09:12:38AM -0800, Ben Pfaff wrote: > Don't panic, this is not a remote buffer overflow, only a bug in a program > parsing its input from the command line or a file. > > Found by inspection. > > Signed-off-by: Ben Pfaff This could still use a review. _

[ovs-dev] [PATCH] learn: Fix buffer overflow in parsing "learn" action strings.

2015-02-25 Thread Ben Pfaff
Don't panic, this is not a remote buffer overflow, only a bug in a program parsing its input from the command line or a file. Found by inspection. Signed-off-by: Ben Pfaff --- lib/learn.c| 6 +- tests/learn.at | 14 ++ 2 files changed, 19 insertions(+), 1 deletion(-) diff