Re: [ovs-dev] [PATCH] lacp: Notify LACP module when carrier changes.

2012-03-07 Thread Ben Pfaff
On Wed, Mar 07, 2012 at 02:51:12PM -0800, Ethan Jackson wrote: > Without this patch, when a slave's carrier goes down, the LACP > module (as evidenced by ovs-appctl lacp/show) would consider the > slave current until it hadn't received LACP PDUs for the requisite > amount of time. It should instea

[ovs-dev] [PATCH] lacp: Notify LACP module when carrier changes.

2012-03-07 Thread Ethan Jackson
Without this patch, when a slave's carrier goes down, the LACP module (as evidenced by ovs-appctl lacp/show) would consider the slave current until it hadn't received LACP PDUs for the requisite amount of time. It should instead, immediately mark the slave expired. This shouldn't actually affect

Re: [ovs-dev] [PATCH] lacp: Notify LACP module when carrier changes.

2012-03-07 Thread Ben Pfaff
On Fri, Mar 02, 2012 at 02:23:56PM -0800, Ethan Jackson wrote: > This patch shouldn't actually affect the behavior of LACP bonds > because the bond module won't choose to send traffic out a slave > whose carrier is down. > > Signed-off-by: Ethan Jackson I see where port->carrier_seq gets initial

[ovs-dev] [PATCH] lacp: Notify LACP module when carrier changes.

2012-03-02 Thread Ethan Jackson
This patch shouldn't actually affect the behavior of LACP bonds because the bond module won't choose to send traffic out a slave whose carrier is down. Signed-off-by: Ethan Jackson --- lib/lacp.c | 10 ++ ofproto/ofproto-dpif.c |7 +++ 2 files changed, 13 insertions