Re: [ovs-dev] [PATCH] jsonrpc: Fix Python implementation of inactivity logic.

2012-09-18 Thread Ben Pfaff
On Mon, Sep 17, 2012 at 10:28:02AM -0700, Gurucharan Shetty wrote: > On Fri, Sep 14, 2012 at 1:19 PM, Ben Pfaff wrote: > > > When a JSON-RPC session receives bytes, or when it successfully sends > > queued bytes, then it should count that as activity. However, the code > > here was reversed, in

Re: [ovs-dev] [PATCH] jsonrpc: Fix Python implementation of inactivity logic.

2012-09-17 Thread Gurucharan Shetty
On Fri, Sep 14, 2012 at 1:19 PM, Ben Pfaff wrote: > When a JSON-RPC session receives bytes, or when it successfully sends > queued bytes, then it should count that as activity. However, the code > here was reversed, in that it used the wrong check in each place. That is, > when it tried to rece

[ovs-dev] [PATCH] jsonrpc: Fix Python implementation of inactivity logic.

2012-09-14 Thread Ben Pfaff
When a JSON-RPC session receives bytes, or when it successfully sends queued bytes, then it should count that as activity. However, the code here was reversed, in that it used the wrong check in each place. That is, when it tried to receive data, it would check whether data had just been sent, an