Re: [ovs-dev] [PATCH] hmap_random_node: Improve distribution

2014-04-22 Thread Ben Pfaff
I understand now. Thank you. This patch looks good, then. Please add your explanation to the commit message. On Apr 22, 2014 5:28 PM, "YAMAMOTO Takashi" wrote: > > On Tue, Apr 22, 2014 at 01:47:32PM +0900, YAMAMOTO Takashi wrote: > >> Improve random distribution for an hmap with a small number o

Re: [ovs-dev] [PATCH] hmap_random_node: Improve distribution

2014-04-22 Thread YAMAMOTO Takashi
> On Tue, Apr 22, 2014 at 01:47:32PM +0900, YAMAMOTO Takashi wrote: >> Improve random distribution for an hmap with a small number of nodes >> with the expense of the increased cpu cost. >> It would be a fair trade-off because the situation is rather common >> for bond, which is currently the only

Re: [ovs-dev] [PATCH] hmap_random_node: Improve distribution

2014-04-22 Thread Ben Pfaff
On Tue, Apr 22, 2014 at 01:47:32PM +0900, YAMAMOTO Takashi wrote: > Improve random distribution for an hmap with a small number of nodes > with the expense of the increased cpu cost. > It would be a fair trade-off because the situation is rather common > for bond, which is currently the only consum

[ovs-dev] [PATCH] hmap_random_node: Improve distribution

2014-04-21 Thread YAMAMOTO Takashi
Improve random distribution for an hmap with a small number of nodes with the expense of the increased cpu cost. It would be a fair trade-off because the situation is rather common for bond, which is currently the only consumer of this API in tree. Signed-off-by: YAMAMOTO Takashi --- lib/hmap.c