Re: [ovs-dev] [PATCH] flow: New function hash_ofp_port() and hash_ofp_port().

2013-06-24 Thread Ethan Jackson
> Alex originally had one of these but I didn't think it was necessary. > However, I think that your two votes override mine on something that I > don't care about too much so: I think with the code as it is now, it could go either way, but I'm adding more ofp_port hashers in future patches, and I

Re: [ovs-dev] [PATCH] flow: New function hash_ofp_port() and hash_ofp_port().

2013-06-24 Thread Ben Pfaff
On Mon, Jun 24, 2013 at 01:59:09PM -0700, Ethan Jackson wrote: > These functions are used so often, that having an easy to read > helper is worth it. > > Signed-off-by: Ethan Jackson Alex originally had one of these but I didn't think it was necessary. However, I think that your two votes overri

[ovs-dev] [PATCH] flow: New function hash_ofp_port() and hash_ofp_port().

2013-06-24 Thread Ethan Jackson
These functions are used so often, that having an easy to read helper is worth it. Signed-off-by: Ethan Jackson --- lib/flow.h | 12 lib/learning-switch.c|4 ++-- ofproto/ofproto-dpif-sflow.c |7 +++ ofproto/ofproto-dpif.c |9 ---