Joe Stringer
mailto:joestrin...@nicira.com>>
Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org>"
mailto:dev@openvswitch.org>>
Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Implement batched flow dumping.
Hey Joe,
Not sure if you were looking at this patch, but I bel
PM
To: Joe Stringer mailto:joestrin...@nicira.com>>
Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org>"
mailto:dev@openvswitch.org>>
Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Implement batched flow dumping.
Hi Ryan, a few broad comments:
Could you split this in
> Hi Ryan, a few broad comments:
>
> Could you split this into two patches, the dpif interface change and the
> dpif-netdev implementation change?
>
>
Sure will do.
> I'm a little uneasy about the change to the dpif_flow_dump_next()
> interface, just because the size of the output parameter was p
Hi Ryan, a few broad comments:
Could you split this into two patches, the dpif interface change and the
dpif-netdev implementation change?
I'm a little uneasy about the change to the dpif_flow_dump_next()
interface, just because the size of the output parameter was previously
paired with the outp
Previously, flows were retrieved one by one when dumping flows for
datapaths of type 'netdev'. This increased contention for the dump's
mutex, negatively affecting revalidator performance.
This patch retrieves batches of flows when dumping flows for datapaths
of type 'netdev'.
Signed-off-by: Ryan
