Re: [ovs-dev] [PATCH] dpif-netdev: Fix crash in dpif_netdev_execute().

2016-10-12 Thread Daniele Di Proietto
On 12/10/2016 12:37, "Ben Pfaff" wrote: >On Tue, Oct 04, 2016 at 04:25:35PM -0700, Daniele Di Proietto wrote: >> dp_netdev_get_pmd() is allowed to return NULL (even if we call it with >> NON_PMD_CORE_ID) for different reasons: >> >> * Since we use RCU to protect pmd threads, it is possible

Re: [ovs-dev] [PATCH] dpif-netdev: Fix crash in dpif_netdev_execute().

2016-10-12 Thread Ben Pfaff
On Tue, Oct 04, 2016 at 04:25:35PM -0700, Daniele Di Proietto wrote: > dp_netdev_get_pmd() is allowed to return NULL (even if we call it with > NON_PMD_CORE_ID) for different reasons: > > * Since we use RCU to protect pmd threads, it is possible that > ovs_refcount_try_ref_rcu() has failed. > *

[ovs-dev] [PATCH] dpif-netdev: Fix crash in dpif_netdev_execute().

2016-10-04 Thread Daniele Di Proietto
dp_netdev_get_pmd() is allowed to return NULL (even if we call it with NON_PMD_CORE_ID) for different reasons: * Since we use RCU to protect pmd threads, it is possible that ovs_refcount_try_ref_rcu() has failed. * During reconfiguration we destroy every thread. This commit makes sure that we a