Re: [ovs-dev] [PATCH] dpif-netdev: Always serialise recirc_id to upcall key.

2014-05-11 Thread Joe Stringer
On 10 May 2014 03:14, Ben Pfaff wrote: > On Fri, May 09, 2014 at 02:35:44PM +1200, Joe Stringer wrote: > > This was causing a mismatch between the odp flow key in an upcall > > compared to the odp flow key that is serialised upon flow_dump. > > > > Signed-off-by: Joe Stringer > > I agree that t

Re: [ovs-dev] [PATCH] dpif-netdev: Always serialise recirc_id to upcall key.

2014-05-09 Thread Andy Zhou
I believe Joe is working on V2 to address a similar issue with dp_hash. I chatted with him last night. The OF rule lookup in the user space will always generate exact match for recirc id, Causing flow dump to always encode both key and mask for recirc_id. On Fri, May 9, 2014 at 8:14 AM, Ben Pfa

Re: [ovs-dev] [PATCH] dpif-netdev: Always serialise recirc_id to upcall key.

2014-05-09 Thread Ben Pfaff
On Fri, May 09, 2014 at 02:35:44PM +1200, Joe Stringer wrote: > This was causing a mismatch between the odp flow key in an upcall > compared to the odp flow key that is serialised upon flow_dump. > > Signed-off-by: Joe Stringer I agree that the flow keys that appear in the flow dump and in upcal

[ovs-dev] [PATCH] dpif-netdev: Always serialise recirc_id to upcall key.

2014-05-08 Thread Joe Stringer
This was causing a mismatch between the odp flow key in an upcall compared to the odp flow key that is serialised upon flow_dump. Signed-off-by: Joe Stringer --- lib/dpif-netdev.c | 21 +++-- tests/ofproto-dpif.at | 116 - 2 files change