Re: [ovs-dev] [PATCH] dpif-linux: Don't reset kernel upcall_pids unintentionally.

2011-10-10 Thread Ben Pfaff
On Mon, Oct 10, 2011 at 09:56:18AM -0700, Jesse Gross wrote: > On Fri, Oct 7, 2011 at 7:54 PM, Ben Pfaff wrote: > > On Fri, Oct 07, 2011 at 06:25:57PM -0700, Jesse Gross wrote: > >> On Fri, Oct 7, 2011 at 5:57 PM, Ben Pfaff wrote: > >> > On Fri, Oct 07, 2011 at 05:05:15PM -0700, Jesse Gross wrote

Re: [ovs-dev] [PATCH] dpif-linux: Don't reset kernel upcall_pids unintentionally.

2011-10-10 Thread Jesse Gross
On Fri, Oct 7, 2011 at 7:54 PM, Ben Pfaff wrote: > On Fri, Oct 07, 2011 at 06:25:57PM -0700, Jesse Gross wrote: >> On Fri, Oct 7, 2011 at 5:57 PM, Ben Pfaff wrote: >> > On Fri, Oct 07, 2011 at 05:05:15PM -0700, Jesse Gross wrote: >> >> On Fri, Oct 7, 2011 at 4:42 PM, Ben Pfaff wrote: >> >> > Com

Re: [ovs-dev] [PATCH] dpif-linux: Don't reset kernel upcall_pids unintentionally.

2011-10-07 Thread Ben Pfaff
On Fri, Oct 07, 2011 at 06:25:57PM -0700, Jesse Gross wrote: > On Fri, Oct 7, 2011 at 5:57 PM, Ben Pfaff wrote: > > On Fri, Oct 07, 2011 at 05:05:15PM -0700, Jesse Gross wrote: > >> On Fri, Oct 7, 2011 at 4:42 PM, Ben Pfaff wrote: > >> > Commit b063d9f0 "datapath: Use unicast Netlink sockets for

Re: [ovs-dev] [PATCH] dpif-linux: Don't reset kernel upcall_pids unintentionally.

2011-10-07 Thread Jesse Gross
On Fri, Oct 7, 2011 at 5:57 PM, Ben Pfaff wrote: > On Fri, Oct 07, 2011 at 05:05:15PM -0700, Jesse Gross wrote: >> On Fri, Oct 7, 2011 at 4:42 PM, Ben Pfaff wrote: >> > Commit b063d9f0 "datapath: Use unicast Netlink sockets for upcalls" that >> > introduced an 'upcall_pid' member into struct dpif

Re: [ovs-dev] [PATCH] dpif-linux: Don't reset kernel upcall_pids unintentionally.

2011-10-07 Thread Ben Pfaff
On Fri, Oct 07, 2011 at 05:05:15PM -0700, Jesse Gross wrote: > On Fri, Oct 7, 2011 at 4:42 PM, Ben Pfaff wrote: > > Commit b063d9f0 "datapath: Use unicast Netlink sockets for upcalls" that > > introduced an 'upcall_pid' member into struct dpif_linux_vport, struct > > dpif_linux_dp, and struct dpif

Re: [ovs-dev] [PATCH] dpif-linux: Don't reset kernel upcall_pids unintentionally.

2011-10-07 Thread Jesse Gross
On Fri, Oct 7, 2011 at 4:42 PM, Ben Pfaff wrote: > Commit b063d9f0 "datapath: Use unicast Netlink sockets for upcalls" that > introduced an 'upcall_pid' member into struct dpif_linux_vport, struct > dpif_linux_dp, and struct dpif_linux_flow neglected to do so only if the > member was nonzero.  Thi

[ovs-dev] [PATCH] dpif-linux: Don't reset kernel upcall_pids unintentionally.

2011-10-07 Thread Ben Pfaff
Commit b063d9f0 "datapath: Use unicast Netlink sockets for upcalls" that introduced an 'upcall_pid' member into struct dpif_linux_vport, struct dpif_linux_dp, and struct dpif_linux_flow neglected to do so only if the member was nonzero. This caused every datapath, vport, and flow operation to supp