Re: [ovs-dev] [PATCH] dpif: Improve logging of upcalls.

2011-06-09 Thread Ben Pfaff
Thanks, pushed. On Wed, Jun 08, 2011 at 05:58:41PM -0700, Ethan Jackson wrote: > Looks Good. > > Ethan > > On Wed, Jun 8, 2011 at 14:04, Ben Pfaff wrote: > > The kernel now provides the entire flow key for a packet sent up to > > userspace, but dpif_recv() would only log the in_port. ?This chan

Re: [ovs-dev] [PATCH] dpif: Improve logging of upcalls.

2011-06-08 Thread Ethan Jackson
Looks Good. Ethan On Wed, Jun 8, 2011 at 14:04, Ben Pfaff wrote: > The kernel now provides the entire flow key for a packet sent up to > userspace, but dpif_recv() would only log the in_port.  This change makes > userspace log the entire flow key. > > This would have made a bug that I recently l

[ovs-dev] [PATCH] dpif: Improve logging of upcalls.

2011-06-08 Thread Ben Pfaff
The kernel now provides the entire flow key for a packet sent up to userspace, but dpif_recv() would only log the in_port. This change makes userspace log the entire flow key. This would have made a bug that I recently looked at a bit easier to investigate. --- lib/dpif.c | 42