Re: [ovs-dev] [PATCH] dpif: Fix slow action handling for DP_HASH and RECIRC

2014-06-03 Thread Ben Pfaff
Thanks! On Tue, Jun 03, 2014 at 02:30:12PM -0700, Andy Zhou wrote: > Ben, thanks for the review. Both are valid. > > I will send out a V2 soon that should address both points. > > On Thu, May 29, 2014 at 2:02 PM, Ben Pfaff wrote: > > On Wed, May 28, 2014 at 05:00:48PM -0700, Andy Zhou wrote: >

Re: [ovs-dev] [PATCH] dpif: Fix slow action handling for DP_HASH and RECIRC

2014-06-03 Thread Andy Zhou
Ben, thanks for the review. Both are valid. I will send out a V2 soon that should address both points. On Thu, May 29, 2014 at 2:02 PM, Ben Pfaff wrote: > On Wed, May 28, 2014 at 05:00:48PM -0700, Andy Zhou wrote: >> In case DP_HASH and RECIRC actions need to be executed in slow path, >> current

Re: [ovs-dev] [PATCH] dpif: Fix slow action handling for DP_HASH and RECIRC

2014-05-29 Thread Ben Pfaff
On Wed, May 28, 2014 at 05:00:48PM -0700, Andy Zhou wrote: > In case DP_HASH and RECIRC actions need to be executed in slow path, > current implementation simply don't handle them -- vswitchd simply > crashes. This patch fixes them by supply an implementation for them. > > RECIRC will be handled b

[ovs-dev] [PATCH] dpif: Fix slow action handling for DP_HASH and RECIRC

2014-05-28 Thread Andy Zhou
In case DP_HASH and RECIRC actions need to be executed in slow path, current implementation simply don't handle them -- vswitchd simply crashes. This patch fixes them by supply an implementation for them. RECIRC will be handled by the datapath, same as the output action. DP_HASH, on the other han